docs(mixed): improve perf & bundle size, fix issue with /layouts #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Jun 9, 2019
| @@ -17,7 +17,7 @@ const App = ({ componentMenu, versions }) => ( | |||
| * We can't place <Sidebar /> inside of <Routes /> because it will be remounted on page | |||
| * switch. We also don't want to show <Sidebar /> for layouts pages and maximized pages. | |||
| */} | |||
| <Route path='/layouts/*' component={null} /> | |||
| <Route exact path='/layouts/:name' component={null} /> | |||
There was a problem hiding this comment.
Because /layouts because same the same prefix, we had match there and sidebar was hidden 💥
Codecov Report
@@ Coverage Diff @@
## master #3652 +/- ##
=========================================
Coverage ? 99.81%
=========================================
Files ? 174
Lines ? 2749
Branches ? 0
=========================================
Hits ? 2744
Misses ? 5
Partials ? 0Continue to review full report at Codecov.
|
layershifter
changed the title
layershifter
force-pushed
the
docs/update-theming
branch
from
e6289db
to
36d5513
Compare
mbakiev
pushed a commit
to mbakiev/Semantic-UI-React
that referenced
this pull request
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3633.
Previously we had broken match on
/layouts, see #3652 (comment).Fixes #3645.
Mention about
semantic-uipackage was removed, we have dedicated page with instructions for theming.Fixes #3659.
Instructions were updated, also added NPM to commands.
Polishes a little bit shorthand docs.