Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): search does not preserve value #3584

Merged
merged 3 commits into from
Jun 9, 2019

Conversation

mihai-dinculescu
Copy link
Member

@mihai-dinculescu mihai-dinculescu commented Apr 25, 2019

Fixes #3552.

@codecov-io
Copy link

codecov-io commented Apr 25, 2019

Codecov Report

Merging #3584 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3584      +/-   ##
==========================================
+ Coverage   99.81%   99.81%   +<.01%     
==========================================
  Files         174      174              
  Lines        2745     2747       +2     
==========================================
+ Hits         2740     2742       +2     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae8576...ae42cf7. Read the comment docs.

@mihai-dinculescu mihai-dinculescu changed the title Fix(Dropdown): Dropdown: Search does not preserve value Fix(Dropdown): Search does not preserve value Apr 26, 2019
@aschumahua
Copy link

Hi @mihai-dinculescu ! How soon can we get this change?

@maxnathaniel
Copy link

Does this fix work? If so, can we merge this ASAP? Thank you.

@layershifter layershifter changed the title Fix(Dropdown): Search does not preserve value fix(Dropdown): search does not preserve value Jun 9, 2019
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add UTs and will merge 👍

@layershifter layershifter merged commit f3abc92 into Semantic-Org:master Jun 9, 2019
@maxnathaniel
Copy link

Thanks for the fix and merge! Wondering if there is a tentive date for v0.88.0 release?

@layershifter
Copy link
Member

I am planing to make it during next week, there will be no breaking changes so it should be 0.87.2.

@maxnathaniel
Copy link

Great, looking forward! Thank you

mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
@RRSR
Copy link

RRSR commented Feb 24, 2020

Hi team, I have updated my semantic-ui-react version to 0.87.2 from 0.84.0. But I am facing an issue related to dropdown, where after typing a search text if I select an option from the filtered out list that element get selected but the element at the same index get highlighted too. I am unable to reproduce the same in codesandbox.

Any help is appreciated.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: Search does not preserve value
6 participants