Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): fully remove debug in production #3485

Merged
merged 3 commits into from
Mar 10, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Mar 10, 2019

Fixes ##3484. This PR:

  • fixes issue with not fully remove debug part in CJS builds, see lib/index.js, var _debug = require("./debug"); was present there
  • removes debug() function as it was never used

@codecov-io
Copy link

codecov-io commented Mar 10, 2019

Codecov Report

Merging #3485 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3485   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         172      172           
  Lines        2802     2802           
=======================================
  Hits         2797     2797           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce521fc...b04395d. Read the comment docs.

@layershifter layershifter merged commit 5086470 into master Mar 10, 2019
@layershifter layershifter deleted the fix/debug-in-production branch March 10, 2019 09:34
@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants