Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown propTypes and docs update #348

Merged
merged 2 commits into from
Jul 25, 2016
Merged

Dropdown propTypes and docs update #348

merged 2 commits into from
Jul 25, 2016

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Jul 25, 2016 •
edited
Loading

This PR updates Dropdown prop types to be more robust. Selection dropdowns require options and exclude use of children and vice versa. Dropdowns with children (example, file menus) require text.

@codecov-io
Copy link

Current coverage is 92.57% (diff: 100%)

No coverage report found for master at 73bd0c4.

Powered by Codecov. Last update 73bd0c4...a8a3491

@levithomason levithomason merged commit 62ce636 into master Jul 25, 2016
@levithomason levithomason deleted the feature/dropdown-prop-warnings branch July 25, 2016 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levithomason @codecov-io