Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Sidebar|Visibility): use createRef() API internally #3455

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

layershifter
Copy link
Member

This PR continues adoption of createRef(), no user-facing changes.

@codecov-io
Copy link

Codecov Report

Merging #3455 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3455      +/-   ##
==========================================
- Coverage   99.89%   99.89%   -0.01%     
==========================================
  Files         172      172              
  Lines        2825     2823       -2     
==========================================
- Hits         2822     2820       -2     
  Misses          3        3
Impacted Files Coverage Δ
src/behaviors/Visibility/Visibility.js 100% <100%> (ø) ⬆️
src/modules/Sidebar/Sidebar.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff3563...990c289. Read the comment docs.

@layershifter layershifter merged commit b5c65ed into master Feb 22, 2019
@layershifter layershifter deleted the chore/vis-sidebar-ref branch February 22, 2019 17:56
@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants