Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): correctly handle focus value in state #3445

Merged
merged 1 commit into from
Feb 17, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Feb 17, 2019

Fixes a regression introduced in #3428.


Regression

The value of focus in a state wasn't handled correctly previously.

regress

After

rec1
rec2

@codecov-io
Copy link

Codecov Report

Merging #3445 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3445   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         172      172           
  Lines        2819     2819           
=======================================
  Hits         2817     2817           
  Misses          2        2
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d1856e...3e9fa6f. Read the comment docs.

@layershifter layershifter merged commit 1623e5c into master Feb 17, 2019
@layershifter layershifter deleted the fix/dropdown-focus-out branch February 17, 2019 13:00
@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants