chore(package): update karma and webpack #3383
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3383 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 170 170
Lines 2809 2809
=======================================
Hits 2806 2806
Misses 3 3Continue to review full report at Codecov.
|
| @@ -91,12 +91,8 @@ export default (karmaConfig) => { | |||
| 'test/tests.bundle.js': ['webpack'], | |||
| }, | |||
| webpack: { | |||
| ...webpackConfig, | |||
There was a problem hiding this comment.
This is now spreading keys that aren't applicable to karma's webpack config (name, mode, target, output, etc). I think we should stick with explicitly passing only the keys we want as it was before.
There was a problem hiding this comment.
Now we have only webpack.config.karma.js, so I cleaned up it more and removed name, output, target from there.
mode is required setting for Webpack 4, otherwise it will run in production mode.
|
Yes, we need a faster runner. Test optimization is needed in this project. |
|
Released in |
This PR breaks partial test runs because uses
karma-webpackinstead ofkarma-webpack-with-fast-source-maps. However,karma-webpack-with-fast-source-mapsis outdated and doesn't support Webpack 4.We should switch to Jest if they will improve the performance in Jest 24/25.