Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icon): disabled prop disables onClick #3358

Merged
merged 4 commits into from
Jan 2, 2019

Conversation

danielsyang
Copy link
Contributor

@danielsyang danielsyang commented Dec 31, 2018

Added behaviour of not running onClick function when Icon is disabled.
Very similar with what is already available in the Button component.

Fixes #3341.

@welcome
Copy link

welcome bot commented Dec 31, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Dec 31, 2018

Codecov Report

Merging #3358 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3358      +/-   ##
==========================================
+ Coverage   99.89%   99.89%   +<.01%     
==========================================
  Files         170      170              
  Lines        2807     2812       +5     
==========================================
+ Hits         2804     2809       +5     
  Misses          3        3
Impacted Files Coverage Δ
src/elements/Icon/Icon.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c383d8...5e6e6ca. Read the comment docs.

@layershifter layershifter changed the title Added handleClick inside Icon so that it can stop running onClick if … feat(Icon): disabled prop disables onClick Jan 2, 2019
@layershifter layershifter merged commit 2598403 into Semantic-Org:master Jan 2, 2019
@welcome
Copy link

welcome bot commented Jan 2, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@spencer-brown
Copy link

Awesome. Thanks, @shuminyang !

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants