New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Icon onClick callback event disbled for 'disabled' props #3357

Closed

harish-a wants to merge 1 commit into Semantic-Org:master from harish-a:iconDisabledClickHandled

Contributor

harish-a commented Dec 31, 2018

As requested in issue #3341, I have added fix for that issue.


          Fix: Icon onClick callback event disbled for 'disabled' props

d06d004

welcome bot commented Dec 31, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
Run yarn test locally to catch errors. This ensures all components still behave as they should.
Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

harish-a closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet