Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Comment): spread image props on CommentAvatar #3260

Merged
merged 1 commit into from
Nov 6, 2018
Merged

fix(Comment): spread image props on CommentAvatar #3260

merged 1 commit into from
Nov 6, 2018

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Nov 6, 2018 •
edited
Loading

Fixes #3250.

Before

<div alt='Example' class='avatar'>
  <img src='matt.jpg' />
</div>

After

<div class='avatar'>
  <img alt='Example' src='matt.jpg' />
</div>

layershifter
layershifter commented Nov 6, 2018
View reviewed changes
src/elements/Image/Image.js
@@ -20,8 +21,6 @@ import Dimmer from '../../modules/Dimmer'
import Label from '../Label/Label'
import ImageGroup from './ImageGroup'

const imageProps = ['alt', 'height', 'src', 'srcSet', 'width']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to lib because is reusable.

@codecov-io
Copy link

Codecov Report

Merging #3260 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3260   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         169      169           
  Lines        2802     2802           
=======================================
  Hits         2800     2800           
  Misses          2        2
Impacted Files Coverage Δ
src/views/Comment/CommentAvatar.js 100% <100%> (ø) ⬆️
src/elements/Image/Image.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236bcf8...51bf9b7. Read the comment docs.

@layershifter layershifter merged commit 10219af into master Nov 6, 2018
@layershifter layershifter deleted the fix/comment-avatar branch November 25, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@layershifter @codecov-io