Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unsafe React lifecycles #3244

Closed

Conversation

kohakukun
Copy link
Contributor

  • Remove unsafe lifecycles:
    • componentWillMount
    • componentWillRecieveProps
    • componentWillUpdate

Relates to #2732

- Remove unsafe lifecycles:
  - `componentWillMount`
  - `componentWillRecieveProps`
  - `componentWillUpdate`

Relates to Semantic-Org#2732
@welcome
Copy link

welcome bot commented Oct 28, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter
Copy link
Member

Looks awesome, but can we split this PR to smaller for 5-6 files per PR?

@kohakukun
Copy link
Contributor Author

Sure, I'll update first the autocontrolled component and follow from that

@kohakukun kohakukun closed this Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants