-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Modal|Confirm): sort size
prop in sizes order
#3237
Conversation
Simple fix to correct the size property enumeration in the documentation for Modal and Confirm components. Previously the ordering was not uniform (smallest -> largest or largest -> smallest).
Codecov Report
@@ Coverage Diff @@
## master #3237 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 169 169
Lines 2802 2802
=======================================
Hits 2800 2800
Misses 2 2
Continue to review full report at Codecov.
|
More broadly I am curious why the |
Because there are no real ability to implement this feature for children API without over complications (i.e. Context API) while Shorthand API allows to define callbacks with |
Gotcha, thanks for the feedback. |
size
prop in sizes order
@fcwheat thank you 👍 |
Simple fix to correct the size property enumeration in the documentation for Modal and Confirm components. Previously the ordering was not uniform (smallest -> largest or largest -> smallest).