Classes & Props: Checkbox #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,8 +19,9 @@ import $ from 'jquery'; | |||
| * <Checkbox type='toggle' /> | |||
| */ | |||
| @radium | |||
| class Checkbox extends Component { | |||
| export default class Checkbox extends Component { | |||
There was a problem hiding this comment.
Export inline, instead of at the end of the file.
| <div className={classes} style={this.props.style} ref='container'> | ||
| <input defaultChecked={this.props.defaultChecked} type='checkbox' name={name} ref='checkbox' /> | ||
| <div className={classes} ref='container'> | ||
| <input {...checkboxProps} ref='checkbox' /> |
There was a problem hiding this comment.
Only spread non class props, since classes belong on the containing div.
There was a problem hiding this comment.
nifty, will we plan to implement this with every stardust component?
There was a problem hiding this comment.
haha this way cleaner than trying to determine whether or not it's a className >.< +1
There was a problem hiding this comment.
@athurman yep, every component is getting this update.
|
Looks good! 🌊 🐙 |
|
🍂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.