Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Grid): fix typo in GridExampleStretched example description #3167

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

sgarrity
Copy link
Contributor

The description of the stretched property of a grid row mentioned 'width', but should have mentioned 'height'.

The description of the `stretched` property of a grid row mentioned 'width', but should have mentioned 'height'.
@welcome
Copy link

welcome bot commented Sep 19, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3167   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         163      163           
  Lines        2746     2746           
=======================================
  Hits         2744     2744           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4243a...30d2353. Read the comment docs.

@layershifter layershifter changed the title Fix typo in Stretched grid example description docs(Grid): fix typo in GridExampleStretched example description Sep 24, 2018
@layershifter layershifter merged commit 663d44f into Semantic-Org:master Sep 24, 2018
@welcome
Copy link

welcome bot commented Sep 24, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants