Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(List): allow overriding role prop #3125

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

johannao76
Copy link
Contributor

Update List and ListItem components to move ...rest to the end of the props list during render. This allows the user to override props like the aria role (which I need in my case).

@welcome
Copy link

welcome bot commented Sep 4, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3125   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         163      163           
  Lines        2742     2742           
=======================================
  Hits         2740     2740           
  Misses          2        2
Impacted Files Coverage Δ
src/elements/List/List.js 100% <ø> (ø) ⬆️
src/elements/List/ListItem.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7cd79...63228ce. Read the comment docs.

@levithomason
Copy link
Member

Looks great, thanks!

@levithomason levithomason changed the title List: Enable prop override by moving ...rest to the end of the props lst feat(List): allow overriding role prop Sep 4, 2018
@levithomason levithomason merged commit 49955ac into Semantic-Org:master Sep 4, 2018
@welcome
Copy link

welcome bot commented Sep 4, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants