Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): fix deepEqual bug #3104

Merged
merged 4 commits into from
Sep 10, 2018

Conversation

pedromtorres
Copy link
Contributor

@pedromtorres pedromtorres commented Aug 23, 2018

Fixes #3000.

@welcome
Copy link

welcome bot commented Aug 23, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #3104 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3104      +/-   ##
==========================================
- Coverage   99.92%   99.92%   -0.01%     
==========================================
  Files         163      163              
  Lines        2742     2740       -2     
==========================================
- Hits         2740     2738       -2     
  Misses          2        2
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 99.75% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0688a...077d8e4. Read the comment docs.

@mvanlonden
Copy link

This fixes the same issue I'm running into

@levithomason
Copy link
Member

I linked the issue to the code change. Tests just need to pass. Thanks for the PR!

@layershifter layershifter changed the title Fix dropdown deep equal bug fix(Dropdown): fix deepEqual bug Aug 27, 2018
@joetuson
Copy link

joetuson commented Sep 6, 2018

Would love to see this merged. Seems like codecov is stalled?

Thanks for all the work you do!

@levithomason levithomason merged commit f04d218 into Semantic-Org:master Sep 10, 2018
@welcome
Copy link

welcome bot commented Sep 10, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants