chore(Sidebar): use EventStack component #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Fediashov <[email protected]>
added 9 commits
July 13, 2018 12:33
Signed-off-by: Oleksandr Fediashov <[email protected]>
Signed-off-by: Oleksandr Fediashov <[email protected]>
Signed-off-by: Oleksandr Fediashov <[email protected]>
Signed-off-by: Oleksandr Fediashov <[email protected]>
Signed-off-by: Oleksandr Fediashov <[email protected]>
Signed-off-by: Oleksandr Fediashov <[email protected]>
Signed-off-by: Oleksandr Fediashov <[email protected]>
Signed-off-by: Oleksandr Fediashov <[email protected]>
Signed-off-by: Oleksandr Fediashov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2990 +/- ##
==========================================
- Coverage 99.92% 99.92% -0.01%
==========================================
Files 169 169
Lines 2801 2790 -11
==========================================
- Hits 2799 2788 -11
Misses 2 2
Continue to review full report at Codecov.
|
layershifter
commented
Jul 13, 2018
src/modules/Sidebar/Sidebar.js
Outdated
| @@ -191,6 +162,7 @@ class Sidebar extends Component { | |||
| <Ref innerRef={this.handleRef}> | |||
| <ElementType {...rest} className={classes}> | |||
| {childrenUtils.isNil(children) ? content : children} | |||
| {visible && <EventStack name={'click'} on={this.handleDocumentClick} />} | |||
There was a problem hiding this comment.
30 lines vs 1 line, exciting result ✌️
There was a problem hiding this comment.
Very cool, I'll give this a proper review before merging. It looks like a fantastic idea :D
…React into feat/eventstack # Conflicts: # package.json # yarn.lock
|
I assume the future of this component will change now that we're publishing EventStack from elsewhere (eventually Stardust)? |
|
Yep, I will move this component to a package. |
…Org/Semantic-UI-React into feat/eventstack # Conflicts: # src/modules/Sidebar/Sidebar.js
layershifter
changed the title
added 2 commits
October 3, 2018 12:44
…React into feat/eventstack
Signed-off-by: Oleksandr Fediashov <[email protected]>
|
Released in |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a cool API called EventStack. It's time to make it more awesome 🐱 This PR offers a new component exposes the EventStack API as public and provides a declarative way to manage it.
This will allow to reduce complexility with subscribtions to events and will allow our users to work with our API deeply.