Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Search): update layout for search example to accommodate code #2948

Merged

Conversation

crashuniverse
Copy link
Contributor

@crashuniverse crashuniverse commented Jun 25, 2018

Fake data used in a pre tag in search example makes content overflow
& leaves a place for improvement. The example at SUI doesn't face
such problems because the state is not displayed in examples.

I made the following layout decisions to box in the content well and not break existing conventions:

  1. Use a Segment to contain pre like button#usage-attached-events
  2. Have a column with combinations of 6 & 10, and 8 & 8 based on how wide the content of search results need to be displayed.

Fake data used in a pre tag in search example makes content overflow
& leaves a place for improvement. The example at SUI doesn't face
such problems because the state is not displayed in examples.
@welcome
Copy link

welcome bot commented Jun 25, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter layershifter changed the title docs (Search): update layout for search example to accommodate code docs(Search): update layout for search example to accommodate code Jun 25, 2018
@codecov-io
Copy link

Codecov Report

Merging #2948 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2948   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files         161      161           
  Lines        2760     2760           
=======================================
  Hits         2754     2754           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caee404...747b05d. Read the comment docs.

@levithomason levithomason merged commit 7da1dd0 into Semantic-Org:master Jun 25, 2018
@welcome
Copy link

welcome bot commented Jun 25, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants