Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Search): wrap categorized search results with "results" #2909

Merged
merged 3 commits into from
Jun 18, 2018
Merged

fix(Search): wrap categorized search results with "results" #2909

merged 3 commits into from
Jun 18, 2018

Conversation

DennisKo
Copy link
Contributor

fixes #2586

@welcome
Copy link

welcome bot commented Jun 13, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #2909 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2909   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files         161      161           
  Lines        2733     2733           
=======================================
  Hits         2724     2724           
  Misses          9        9
Impacted Files Coverage Δ
src/modules/Search/SearchCategory.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e9b8ba...c8fb86d. Read the comment docs.

@layershifter layershifter changed the title Wrap categorized search results with div.results fix(Search): wrap categorized search results with "results" Jun 14, 2018
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some tests, @DennisKo thanks for PR 👍

@levithomason levithomason merged commit 531d5d1 into Semantic-Org:master Jun 18, 2018
@welcome
Copy link

welcome bot commented Jun 18, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: category/results not displayed correctly
4 participants