fix(Dropdown): stop onOpen from firing twice on icon click

[willb335]

Connects #2600

onOpen is firing twice when Dropdown icon is clicked with a search prop

The change is at line 426. The other changes are from Prettier

[welcome]

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

• Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
• Run yarn test locally to catch errors. This ensures all components still behave as they should.
• Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
• Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[codecov-io]

Codecov Report

Merging #2744 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2744      +/-   ##
==========================================
+ Coverage   99.67%   99.74%   +0.07%     
==========================================
  Files         160      160              
  Lines        2761     2759       -2     
==========================================
  Hits         2752     2752              
+ Misses          9        7       -2

Impacted Files	Coverage Δ
src/modules/Dropdown/Dropdown.js	100% <100%> (ø)	⬆️
src/modules/Search/Search.js	99.46% <0%> (+1.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e55c7d...97957f9. Read the comment docs.

[levithomason]

Great fix, thanks!

Let's also get a test that asserts the callback is .calledOnce(). You can find tests in Dropdown-test.js. We describe() tests by prop, so look for describe('onOpen', ...) (around line 1280).

There are many examples of using .calledOnce in the file you can refer to. We only need one test saying that it('is called once when the icon is clicked', ...). It would also be superb to leave a comment link to the GitHub issue there.

[willb335]

The new test in Dropdown-test.js starts at line 1249. The new test fails as expected without the changes in the first commit.

[levithomason]

Thanks!

[levithomason]

Released in [email protected].