Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Search): debounce search change handler #2650

Merged
merged 2 commits into from
Mar 16, 2018

Conversation

ryanflowers
Copy link
Contributor

@ryanflowers ryanflowers commented Mar 16, 2018

Added a debounce around the search change event as to not execute the callback on every key press. Dropped the timeout to be just under the debounce. This includes standard and category search examples.

… callback on every key press. Dropped the timeout to be just under the debounce.
@welcome
Copy link

welcome bot commented Mar 16, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #2650 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2650   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         160      160           
  Lines        2751     2751           
=======================================
  Hits         2744     2744           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bd1c3d...8705321. Read the comment docs.

@levithomason levithomason changed the title Added a debounce around the search change event docs(Search): debounce search change handler Mar 16, 2018
@levithomason levithomason merged commit c810fb2 into Semantic-Org:master Mar 16, 2018
@welcome
Copy link

welcome bot commented Mar 16, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants