Support multiple dropdown type #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.23%@@ master #254 diff @@
==========================================
Files 62 62
Lines 752 806 +54
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 633 687 +54
Misses 119 119
Partials 0 0
|
levithomason
force-pushed
the
feature/multiple-dropdown
branch
from
b265fc4
to
02e7aa3
Compare
| // convert the value to/from an array | ||
| const newValue = e.target.checked ? _.compact([value]) : value[0] | ||
| this.setState({ multiple: e.target.checked, value: newValue }) | ||
| } |
There was a problem hiding this comment.
Since this example allows toggling the multiple prop, we need to convert the value to and from an array corresponding to the dropdown type.
|
🍂 sqursh enrd rbs tur maestr |
|
|
||
| const _detail = detail || detailLink | ||
| const detailComponent = (detailLink || onClickDetail) && 'a' || detail && 'div' | ||
| const DetailComponent = (detailLink || onDetailClick) && 'a' || 'div' |
There was a problem hiding this comment.
Would be nice to wrap the latter check in () for similar clarity to the initial expression.
There was a problem hiding this comment.
Not seeing where the extra parens can be added here. Here is another way of writing this:
let DetailComponent = 'div'
if (detailLink || onDetailClick) DetailComponent = 'a'
|
👻 LGTM, will pull and test locally if you want before merging. |
levithomason
force-pushed
the
feature/multiple-dropdown
branch
from
e5af50b
to
4cd81a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
multipledropdown type. A multiple dropdown:value(opposed to string/number)Other updates and fixes:
search