test(Portal): fix tests with timeouts #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2538 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 160 160
Lines 2744 2744
=======================================
Hits 2737 2737
Misses 7 7Continue to review full report at Codecov.
|
levithomason
force-pushed
the
fix/portal-tests
branch
from
3d8c9b8 to
54a1a98
Compare
|
Merged as it was marked as |
|
Released in |
Brantron
pushed a commit
to Brantron/Semantic-UI-React
that referenced
this pull request
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransitionablePortaltests are intermittently failing due to unpredictable animation durations and set timeout times.This PR adds a new util
assertWithTimeoutwhich repeatedly makes the assertion until it passes or until 2s have passed. In the event 2s is reached without the assertion passing, the error will be thrown. This allows us to execute tests as fast as possible but also account for unknown execution times.