Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): add 173app to the built with list #2495

Merged
merged 3 commits into from
Feb 14, 2018

Conversation

Carrotzpc
Copy link
Contributor

add https://173app.com to the built with list

add 173app.com to the built with list
@welcome
Copy link

welcome bot commented Feb 5, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@levithomason
Copy link
Member

It seems the CDN is not responding for this app. I'm in the US, west coast. Does it work for you?

@Carrotzpc
Copy link
Contributor Author

@levithomason Yes, it work for me in China. And I test the CDN in the US, Los Angeles by VPN, it can work but slowly.

@levithomason levithomason merged commit befffb8 into Semantic-Org:master Feb 14, 2018
@welcome
Copy link

welcome bot commented Feb 14, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

❤️

@levithomason
Copy link
Member

Released in [email protected].

@Carrotzpc
Copy link
Contributor Author

👍 @levithomason

Brantron pushed a commit to Brantron/Semantic-UI-React that referenced this pull request Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants