fix(AccordionTitle): allow strings in index PropType #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier AccordionTitle's prop index used to typecheck only for number, now it also supports a string. Fixes: Semantic-Org#2478 Signed-off-by: bp <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2483 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 154 154
Lines 2707 2707
=======================================
Hits 2700 2700
Misses 7 7
Continue to review full report at Codecov.
|
|
Looks like the corresponding typings in |
levithomason
changed the title
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Released in |
Brantron
pushed a commit
to Brantron/Semantic-UI-React
that referenced
this pull request
Mar 14, 2018
fix(AccordionTitle): allow strings in index PropType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier AccordionTitle's prop index used to type check only for number,
now it also supports a string.
Fixes: #2478
Signed-off-by: bp [email protected]