Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Step): fix display of an icon in StepExampleEvenlyDivided #2365

Merged
merged 1 commit into from
Dec 10, 2017

Conversation

jeroenvervaeke
Copy link
Contributor

@jeroenvervaeke jeroenvervaeke commented Dec 7, 2017

'Truck' icon wasn't showing in the step docs due to a typo.
Somebody accidentally used the 'icon' attribute instead of the 'name' attribute.

@jeroenvervaeke
Copy link
Contributor Author

The failing test:
onHide
✖ is called with (null, data) when exiting transition finished
Has nothing to do with my changes

@layershifter layershifter changed the title (docs) 'Truck' icon wasn't showing in the step docs due to a typo docs(Step): fix display of an icon in StepExampleEvenlyDivided Dec 10, 2017
@codecov-io
Copy link

Codecov Report

Merging #2365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2365   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files         152      152           
  Lines        2661     2661           
=======================================
  Hits         2654     2654           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fd4a7...e46c298. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeroenvervaeke Thanks for the contribution 👍 You're right, the failed test doesn't have nothing in common with your changes.

I've retriggered build, now it's okay 😸

@layershifter layershifter merged commit 61e9460 into Semantic-Org:master Dec 10, 2017
@levithomason
Copy link
Member

Released in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants