Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): add event handlers when opened via defaultOpen #2334

Merged
merged 1 commit into from
Nov 25, 2017

Conversation

sean-mckenna
Copy link
Contributor

@sean-mckenna sean-mckenna commented Nov 20, 2017

This attaches the event handlers to deal with closing the Dropdown such as onBlur and pressing the esc key.

fixes 2332

This attaches the event handlers to deal with closing the Dropdown such as onBlue and pressing the esc key.

fixes Semantic-Org#2332
@codecov-io
Copy link

Codecov Report

Merging #2334 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2334      +/-   ##
==========================================
+ Coverage   99.73%   99.73%   +<.01%     
==========================================
  Files         152      152              
  Lines        2655     2658       +3     
==========================================
+ Hits         2648     2651       +3     
  Misses          7        7
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2dfbad...27ed2ef. Read the comment docs.

@levithomason levithomason merged commit 4f66e7d into Semantic-Org:master Nov 25, 2017
@levithomason
Copy link
Member

Awesome, thanks!

@levithomason
Copy link
Member

Released in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: Clicking outside the component does not close it when defaultOpen is true
4 participants