Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Grid): allow multiple values for reversed prop #2235

Merged
merged 1 commit into from
Oct 22, 2017

Conversation

layershifter
Copy link
Member

Fixes #2222.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4f29636). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2235   +/-   ##
=========================================
  Coverage          ?   99.73%           
=========================================
  Files             ?      151           
  Lines             ?     2624           
  Branches          ?        0           
=========================================
  Hits              ?     2617           
  Misses            ?        7           
  Partials          ?        0
Impacted Files Coverage Δ
src/collections/Grid/GridColumn.js 100% <ø> (ø)
src/collections/Grid/Grid.js 100% <ø> (ø)
src/collections/Grid/GridRow.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f29636...838eb9e. Read the comment docs.

@levithomason levithomason merged commit 0adef6a into master Oct 22, 2017
@levithomason levithomason deleted the feat/grid-multiple branch October 22, 2017 15:26
@levithomason
Copy link
Member

Awesome, thanks!

@levithomason
Copy link
Member

Released in [email protected]

@Maxhodges
Copy link

what's the syntax for multiple values in reversed? seems undocumented

@gscott
Copy link

gscott commented Nov 20, 2017

@layershifter Is there any chance that some side effect of this change is the source of my compile errors when moving from 0.75.1 to 0.76.0?

./node_modules/semantic-ui-react/dist/es/collections/Grid/GridRow.js
26:128-143 '../../lib' does not contain an export named 'useMultipleProp'.

If I go back to 0.75.1 the issue goes away.

@layershifter
Copy link
Member Author

Please open new issue an fully describe your problem there.

@Semantic-Org Semantic-Org locked and limited conversation to collaborators Nov 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants