Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Views): add <meta name="viewport"> tags to docs #2231

Merged
merged 1 commit into from
Oct 29, 2017

Conversation

RetroCraft
Copy link
Contributor

Fixes #2230.

Lack of tags prevents responsive examples from being responsive. See #2230 for more details.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4f29636). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2231   +/-   ##
=========================================
  Coverage          ?   99.73%           
=========================================
  Files             ?      151           
  Lines             ?     2624           
  Branches          ?        0           
=========================================
  Hits              ?     2617           
  Misses            ?        7           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f29636...3a8457b. Read the comment docs.

@layershifter layershifter changed the title Add <meta name="viewport"> tags to docs docs(Views): add <meta name="viewport"> tags to docs Oct 21, 2017
@levithomason levithomason merged commit 710757b into Semantic-Org:master Oct 29, 2017
@levithomason
Copy link
Member

Released in [email protected]

@oliverbenns
Copy link

This doesn't really fix the docs on mobile. The black sidebar takes up 66% of the width view and cannot be collapsed / hidden.

@layershifter
Copy link
Member

Our docs aren't mobile friendly and this PR should not solve this. Contributions are welcome.

@RetroCraft RetroCraft deleted the patch-1 branch November 15, 2017 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants