Common test for events #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,7 @@ export default class Form extends Component { | |||
| } | |||
|
|
|||
| componentWillUnmount() { | |||
| this.element.off() | |||
| _.invoke(this, 'element.off') | |||
There was a problem hiding this comment.
These don't actually matter since we moving away from jQuery, though, we simply calling this if it exists now. In tests, there is no off().
levithomason
force-pushed
the
feature/common-test-events
branch
3 times, most recently
from
04beb90
to
91e5c18
Compare
| const leftPad = ' '.repeat(constructorName.length + listenerName.length + 3) | ||
|
|
||
| handlerSpy.called.should.equal(true, | ||
| `<${constructorName} ${listenerName}={${handlerName}} />\n` + |
There was a problem hiding this comment.
You can pass back a custom error message? What is this madness.
There was a problem hiding this comment.
Aye, most (all?) assertions allow this. Allows making crappy assertion errors good.
|
👻 |
levithomason
force-pushed
the
feature/common-test-events
branch
from
91e5c18
to
b57619c
Compare
levithomason
force-pushed
the
feature/common-test-events
branch
from
b57619c
to
d7d0a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked By
#222 (synthetic event)Adds common tests for event handling. Also fixes some minor issues with the common tests.