feat(eventStack): support for different targets #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2017 18:10
…React into feat/event-target # Conflicts: # src/behaviors/Visibility/Visibility.js # src/lib/eventStack/EventTarget.js # src/modules/Popup/Popup.js # src/modules/Sticky/Sticky.js
Codecov Report
@@ Coverage Diff @@
## master #2094 +/- ##
==========================================
- Coverage 99.76% 99.76% -0.01%
==========================================
Files 149 149
Lines 2602 2600 -2
==========================================
- Hits 2596 2594 -2
Misses 6 6
Continue to review full report at Codecov.
|
…React into feat/event-target # Conflicts: # src/behaviors/Visibility/Visibility.js
|
Fixed conflict, good to merge once test pass and you confirm. |
|
@levithomason thanks, looks correct 👍 Let's merge this before #2091, because there will be conflict again 😄 |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cut from #2088.
What?
This PR adds ability to use
eventStackon custom targets, exceptdocumentandwindow. This means that we can use it inStickyandVisibilityand gains its benefits 👍In fact, I moved old
eventStacktoEventTargetand fully kept its functionality. NeweventStacknow only manages instances ofEventTargets.