feat(Visibility): add direction for calculations
#2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Sep 20, 2017
| @@ -111,7 +111,7 @@ Any other issue labeled [`help wanted`][4] is ready for a PR. | |||
| |-----------------|-----------------|-----------------|-----------------|--------------------| | |||
| | ✓ Button | ✓ Breadcrumb | ✓ Advertisement | ✓ Accordion | Form Validation | | |||
| | ✓ Container | ✓ Form | ✓ Card | ✓ Checkbox | *API (NA)* | | |||
| | ✓ Divider | ✓ Grid | ✓ Comment | ✓ Dimmer | ✓ Visibility (NA) | | |||
layershifter
force-pushed
the
feat/visibility-direction
branch
from
10f0f0e
to
0adab10
Compare
Codecov Report
@@ Coverage Diff @@
## master #2090 +/- ##
==========================================
+ Coverage 99.76% 99.76% +<.01%
==========================================
Files 149 149
Lines 2598 2601 +3
==========================================
+ Hits 2592 2595 +3
Misses 6 6
Continue to review full report at Codecov.
|
…React into feat/visibility-direction # Conflicts: # src/behaviors/Visibility/Visibility.js
layershifter
force-pushed
the
feat/visibility-direction
branch
from
40ba470
to
6a6c8bd
Compare
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cut from #2088.
What?
SUI has
directionvalue incalculations, this PR adds it into the component. I don't addedstaticvalue because I don't know when it really can be.