-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(package): replace npm with yarn #2081
Conversation
f2f86ac
to
8fc0030
Compare
Well, I cannot seem to figure out why ChromeHeadless is not included with pupeteer when installing with yarn. I will have to come back next time and SSH into the box for more debugging. This is the only thing blocking this PR! |
max callStackWe regularly get max call stack errors on CI, I'm think that we increase this value:
I'm not sure, but it should work. missing libsSeems Docker image of Circle missing required libs. I think that the most correct solution is use own Docker image there.
|
Codecov Report
@@ Coverage Diff @@
## master #2081 +/- ##
==========================================
+ Coverage 96.45% 99.76% +3.31%
==========================================
Files 150 149 -1
Lines 2596 2589 -7
==========================================
+ Hits 2504 2583 +79
+ Misses 92 6 -86
Continue to review full report at Codecov.
|
Thanks for the lead, the list of missing deps was indeed the issue. Instead of managing our own image, I just updated those deps as the first step on CI. We did not, however, have the issues related to sandboxing so I have not added any flags for that. I also added the increased stack trace flag, we'll see if that resolves the maximum call stack exceeded issue! |
Released in |
Praise be. |
NPM is broken.
package-lock.json
still doesn't work, and even if it did, it only works for users using the latestnpm
cli. Users on old versions still get a worse experience a no lock file safety.This PR:
npm
withyarn