Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Visibility): add offset #2016

Merged
merged 4 commits into from
Sep 1, 2017
Merged

feat(Visibility): add offset #2016

merged 4 commits into from
Sep 1, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 29, 2017 •
edited
Loading

Rel #1146.

  • adds the offset prop
  • cleanups Visibility docs, make them more usable

@layershifter layershifter mentioned this pull request Aug 29, 2017
Merged
@codecov-io
Copy link

codecov-io commented Aug 29, 2017 •
edited
Loading

Codecov Report

Merging #2016 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
+ Coverage   99.76%   99.76%   +<.01%     
==========================================
  Files         148      148              
  Lines        2557     2559       +2     
==========================================
+ Hits         2551     2553       +2     
  Misses          6        6
Impacted Files Coverage Δ
src/behaviors/Visibility/Visibility.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f7ceb...f630240. Read the comment docs.

@levithomason
Copy link
Member

Fixed a couple issues with the ComponentExample in this branch. It didn't know how to import the Wireframe component. The examples would not re-render on change, but throw.
Need a better way of resolving modules in the future. Right now, we have a very hacky hard-coded way of resolving modules.

Also, I made some updates to the event log experience and improved performance. It is now truncated to 20 items and shows the total number of callbacks called.

@layershifter
Copy link
Member Author

I solved merge conflicts 👍

@levithomason levithomason merged commit 12107db into master Sep 1, 2017
@levithomason levithomason deleted the feat/visibility-offset branch September 1, 2017 14:58
@levithomason
Copy link
Member

Released in [email protected]

layershifter added a commit that referenced this pull request Sep 11, 2017
@layershifter
feat(Visibility): add offset (#2016)
caa9a0a 
* feat(Visibility): add offset

* fix(ComponentExample): add Wireframe, fix editor padding

* docs(Visibility): better event log ux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@layershifter @codecov-io @levithomason