fix(Dropdown): closeOnBlur={false} does not work #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1998 +/- ##
=========================================
+ Coverage 99.8% 99.8% +<.01%
=========================================
Files 148 148
Lines 2556 2557 +1
=========================================
+ Hits 2551 2552 +1
Misses 5 5
Continue to review full report at Codecov.
|
layershifter
added
ready for review
needs author feedback
and removed
ready for review
labels
layershifter
requested changes
Aug 24, 2017
fix(Dropdown): remove event listener if closeOnBlur={false}
test(Dropdown): add a test for closeOnBlur={false}
fixes #1995
|
Fixed conflicts and rebased to latest master. Will merge on pass, thanks! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(Dropdown): Don't add an event listener for document clicks if closeOnBlur is falsey
test(Dropdown): add a test for closeOnBlur={false}
fixes #1995