perf(docs): optimize performance #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
perf/doc-props
branch
3 times, most recently
from
865f7be
to
f27afc7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1981 +/- ##
======================================
Coverage 99.8% 99.8%
======================================
Files 148 148
Lines 2589 2589
======================================
Hits 2584 2584
Misses 5 5Continue to review full report at Codecov.
|
layershifter
commented
Aug 20, 2017
There was a problem hiding this comment.
@levithomason I've finished this PR, it will be interesting to hear your opinion
layershifter
force-pushed
the
perf/doc-props
branch
from
f27afc7
to
7fc77df
Compare
|
Oh man, this has been on my list for so long ❤️ ! The update all deps PR has made some conflicts here, could you take a look? |
|
@levithomason I'll solve them tomorrow, 22PM there 😴 |
added 2 commits
August 21, 2017 09:56
…React into perf/doc-props # Conflicts: # docs/app/Components/ComponentDoc/ComponentDoc.js # docs/app/Components/ComponentDoc/ComponentExample/ComponentExample.js # docs/app/Components/ComponentDoc/ComponentProps/ComponentProps.js # package.json
layershifter
commented
Aug 21, 2017
There was a problem hiding this comment.
@levithomason I've resolved conficts and merged with master 👍
|
Released in |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is first round of docs performance optimizations. I've profiled our docs page and found that there are two components that aren't optimized:
ComponentExampleandComponentProps.ComponentPropsRenders many elements, has a non-optimized render of enum values. I've refactored it to several small components that have controlled render cycle. I've also refactored usage of double curly braces:
ComponentExampleMy profile showed that the next bottleneck is control items at each example. All of them use
Popupwhich usesPortal, page that has 30 examples produces 120Portals, which rendered immediately. It's not fast.I saw that in fact, it's not necessary because controls should be visible only when example is hovered. I've factored CSS animation with a
Transitioncomponent, so controls will mount only when they will be needed. Each control was optimized, too.