Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): more logic for clearing search #1956

Merged
merged 3 commits into from
Aug 20, 2017
Merged

fix(Dropdown): more logic for clearing search #1956

merged 3 commits into from
Aug 20, 2017

Conversation

lottamus
Copy link
Contributor

@lottamus lottamus commented Aug 11, 2017

Fixes #1952.

* fix(Dropdown): clear search if adding item or if selection is only option

* test(Dropdown): add test for clear search if selection is only option
@levithomason
Copy link
Member

Heads up, tests are failing due to lint:

/home/ubuntu/Semantic-UI-React/src/modules/Dropdown/Dropdown.js
  599:53  error  Extra semicolon  semi
  603:64  error  Extra semicolon  semi
  702:64  error  Extra semicolon  semi
  711:53  error  Extra semicolon  semi

You can run npm run lint:fix to fix most errors and then push. Note that you can ignore warnings.

@codecov-io
Copy link

codecov-io commented Aug 14, 2017

Codecov Report

Merging #1956 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1956      +/-   ##
=========================================
+ Coverage    99.8%   99.8%   +<.01%     
=========================================
  Files         148     148              
  Lines        2568    2573       +5     
=========================================
+ Hits         2563    2568       +5     
  Misses          5       5
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4780cd...6eb1456. Read the comment docs.

@rijk
Copy link
Member

rijk commented Aug 15, 2017

Awesome this will be fixed + the extra tests. Great work @ChrisNLott , hope it will be merged soon, this is really bugging us in production as well.

@levithomason levithomason merged commit 7b94bf2 into Semantic-Org:master Aug 20, 2017
@levithomason
Copy link
Member

Thanks much @ChrisNLott. I'll make a release today.

@levithomason
Copy link
Member

Released in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-select Dropdown does not clear value after "onAddItem"
5 participants