-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dropdown): more logic for clearing search #1956
Conversation
* fix(Dropdown): clear search if adding item or if selection is only option * test(Dropdown): add test for clear search if selection is only option
Heads up, tests are failing due to lint:
You can run |
Codecov Report
@@ Coverage Diff @@
## master #1956 +/- ##
=========================================
+ Coverage 99.8% 99.8% +<.01%
=========================================
Files 148 148
Lines 2568 2573 +5
=========================================
+ Hits 2563 2568 +5
Misses 5 5
Continue to review full report at Codecov.
|
Awesome this will be fixed + the extra tests. Great work @ChrisNLott , hope it will be merged soon, this is really bugging us in production as well. |
Thanks much @ChrisNLott. I'll make a release today. |
Released in |
Fixes #1952.