-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Embed): add iframe shorthand #1810
Conversation
@levithomason There is single failing test:
I can't fix it, looks like a problem with default value |
Requires #1845. |
c7d265c
to
97ad8e1
Compare
…React into feat/embed-iframe
Codecov Report
@@ Coverage Diff @@
## master #1810 +/- ##
==========================================
+ Coverage 99.75% 99.75% +<.01%
==========================================
Files 145 145
Lines 2477 2478 +1
==========================================
+ Hits 2471 2472 +1
Misses 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocked, ready for review 👍
👍 |
Released in |
Fixes #1804.