Fix conformance tests #171
Conversation
levithomason
force-pushed
the
feature/fix-conformance-tests
branch
from
6bf1a4d
to
29acca5
Compare
| @@ -190,28 +190,28 @@ All magic is noted in the documentation examples. | |||
|
|
|||
| ```jsx | |||
| <Form.Field className='inherit-this' /> | |||
| // => <div className='sd-field inherit-this field>... | |||
| // => <div className='sd-form-field inherit-this field>... | |||
There was a problem hiding this comment.
Components were reorganized to sub components in #99:
Field => FormField.
Generated classNames should also follow suit:
className='sd-field' => className='sd-form-field'
Fixing conformance tests pointed this out.
| children: PropTypes.node, | ||
| className: PropTypes.string, | ||
| icon: PropTypes.node, | ||
| image: PropTypes.node, | ||
| }; | ||
| } |
There was a problem hiding this comment.
I love not having the ; on static props. What makes this possible?
There was a problem hiding this comment.
Babel reverting their ridiculous breaking change where they threw errors if you didn't have them ;)
I actually meant to leave all them in and i'll pull them on another PR. Will leave this here for now...
|
Nothing glaring but the ☀️ in my face. ⛵ with comments considered. |
| @@ -65,7 +65,7 @@ export default (config) => { | |||
| progress: false, | |||
| stats: statConfig, | |||
| debug: true, | |||
| noInfo: true, | |||
| noInfo: false, | |||
| import _ from 'lodash' | ||
| import React, { Component, PropTypes } from 'react' | ||
| import classNames from 'classnames' | ||
| import cx from 'classnames' |
There was a problem hiding this comment.
Not relevant to this line... I wonder if it would make sense to make this a pure component and not re-render unless props change. Since it's such a simple (and common) element it might be a nice future feature (or option) to do prop checks to prevent unneeded re-renders.
There was a problem hiding this comment.
Definitely, I've been skipping all optimizations while we crank toward 1.0. This is a great point.
|
👻 w/ comments |
…-tests Fix conformance tests
Fixes a number of oversights and issues with the conformance tests. Also fixes code to conform to now working conformance tests.