docs(types): fix type definitions #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1678 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 141 141
Lines 2410 2410
=======================================
Hits 2404 2404
Misses 6 6
Continue to review full report at Codecov.
|
layershifter
force-pushed
the
docs/fix-types
branch
from
8a37929
to
40225a8
Compare
layershifter
force-pushed
the
docs/fix-types
branch
from
40225a8
to
1f1adb1
Compare
gulp/plugins/util/parseType.js
Outdated
| return item | ||
| }) | ||
|
|
||
| const parseEnum = type => { |
There was a problem hiding this comment.
It looks like this reduces the need for some of the logic in ComponentProps.js:
layershifter
commented
May 17, 2017
|
Awesome, thanks much sir! This will also help with the speed a bit, there's a pretty bad performance bug I need to trace down in the component doc page. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1563.
Before
After