Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(DropdownExamplePointing): Fix nested Dropdown #1644

Merged
merged 2 commits into from
Nov 25, 2017
Merged

docs(DropdownExamplePointing): Fix nested Dropdown #1644

merged 2 commits into from
Nov 25, 2017

Conversation

Jimeno0
Copy link
Contributor

@Jimeno0 Jimeno0 commented Apr 28, 2017

Fix nested dropdown little bug just by adding inside the <Dropdown.Item> submenu
Hope it helps!
🍺

@Jimeno0
docs(DropdownExamplePointing): Fix nested Dropdown
d31f2cf 
Fix nested dropdown little bug just by adding <Dropdown> inside the <Dropdown.Item> submenu
Hope it helps! 
🍺
@Jimeno0 Jimeno0 mentioned this pull request Apr 28, 2017
Closed
layershifter
layershifter requested changes May 4, 2017
View reviewed changes
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jimeno0 Thanks for PR, can you please fix a lint issue with Icon?

@codecov-io
Copy link

codecov-io commented May 5, 2017 •
edited
Loading

Codecov Report

Merging #1644 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1644   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2398     2398           
=======================================
  Hits         2392     2392           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb53e0...5e074b3. Read the comment docs.

@Jimeno0
Copy link
Contributor Author

Jimeno0 commented May 5, 2017 •
edited
Loading

I think that the linting error (unused Icon import ) its now fixed

@levithomason
Copy link
Member

This looks great, we should update all the nested Dropdown examples in this PR.

@levithomason
Copy link
Member

This would also allow us to remove the warning message above many of the examples.

@mwakerman
Copy link

mwakerman commented Nov 21, 2017 •
edited
Loading

How come this hasn't been merged? Are you waiting for the banners to also be removed?

@levithomason levithomason merged commit 2d73c3d into Semantic-Org:master Nov 25, 2017
@levithomason
Copy link
Member

This PR updates one of several examples. Also, some banners could be removed after the updates.
However, some progress is better than none. Will release this soon.

@levithomason
Copy link
Member

Released in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter requested changes

Assignees
No one assigned
Labels
docs needs author feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jimeno0 @codecov-io @levithomason @mwakerman @layershifter