Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): fix warning on PropTypes with React >= 15.5.0 #1588

Merged
merged 1 commit into from
Apr 17, 2017
Merged

fix(Dropdown): fix warning on PropTypes with React >= 15.5.0 #1588

merged 1 commit into from
Apr 17, 2017

Conversation

g1eny0ung
Copy link
Contributor

@g1eny0ung g1eny0ung commented Apr 17, 2017

Fixes #1587

Seems that the commit 3a09c0f missed a PropTypes, so it also has a warning when in developing.

@codecov-io
Copy link

codecov-io commented Apr 17, 2017

Codecov Report

Merging #1588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1588   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2384     2384           
=======================================
  Hits         2378     2378           
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 573a0da...94a4e79. Read the comment docs.

@layershifter layershifter changed the title fixed warning on PropTypes with React >= 15.5.0 fix(Dropdown): fix warning on PropTypes with React >= 15.5.0 Apr 17, 2017
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g1eny0ung Thanks for PR. I overlooked this in #1576

@g1eny0ung
Copy link
Contributor Author

@layershifter 👌🏽

@levithomason levithomason merged commit 0a43956 into Semantic-Org:master Apr 17, 2017
@levithomason
Copy link
Member

Thanks!

@rafaelkallis
Copy link

@levithomason When can we expect the next release including this PR?

@levithomason
Copy link
Member

I release typically about once a week, usually on weekends or Monday. Just released 0.68.0 2 days ago. If there are high priority items, I'll release more often. Since this is just an annoying warning, it'll probably go out this weekend.

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants