Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): relax the label propType validator on FormField #1491

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

rajchourasia
Copy link
Contributor

…ut a label prop

Fixes #1387

@codecov-io
Copy link

codecov-io commented Mar 21, 2017

Codecov Report

Merging #1491 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1491   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2371     2371           
=======================================
  Hits         2365     2365           
  Misses          6        6
Impacted Files Coverage Δ
src/collections/Form/FormField.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd65da...a3ab417. Read the comment docs.

@layershifter layershifter changed the title fix(formfield): relax the label propType validator to allow use witho… fix(Form): relax the label propType validator on FormField Mar 23, 2017
@levithomason levithomason merged commit d0a54fb into Semantic-Org:master Mar 24, 2017
@levithomason
Copy link
Member

Awesome, thanks much!

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants