fix(Dropdown): do not close on click when search is empty

[rajchourasia]

Fixes #1451 . Mimics the behaviour of SUI core in similar scenario.

[codecov-io]

Codecov Report

Merging #1490 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1490      +/-   ##
==========================================
+ Coverage   99.74%   99.74%   +<.01%     
==========================================
  Files         141      141              
  Lines        2371     2378       +7     
==========================================
+ Hits         2365     2372       +7     
  Misses          6        6

Impacted Files	Coverage Δ
src/modules/Dropdown/Dropdown.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd65da...d7ee5bb. Read the comment docs.

[layershifter]

Can we simplify logic there?

toggle = (e) => {
  if (this.state.open) {
    this.open(e)
    return
  }

  const { search } = this.props
  const options = this.getMenuOptions()

  if (search && _.isEmpty(options)) {
    e.preventDefault()
    return
  }

  this.close(e)
}

It looks more readable to me.

[levithomason]

Thanks for writing a test for this as well. This is a good stop-gap for now, however, the SUI core dropdown still allows toggling an empty search dropdown when the icon is clicked:

We should address that at some point.

[levithomason]

Released in [email protected].