-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(bundlers): add webpack 1 example #1452
Conversation
This is great! |
Codecov Report
@@ Coverage Diff @@
## master #1452 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 141 141
Lines 2363 2364 +1
==========================================
+ Hits 2357 2358 +1
Misses 6 6
Continue to review full report at Codecov.
|
@levithomason I need you review there, pay attention to the text added to docs. I want to add same for rollup and webpack 2 in next PRs. |
e5e0d40
to
d5d15bc
Compare
I've started a review here, will need to come back later to finish and submit it. |
I have some comments, but, I want to first get some more examples merged before cleaning up too much. |
Ref: #524