Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bundlers): add webpack 1 example #1452

Merged
merged 3 commits into from
Mar 19, 2017
Merged

docs(bundlers): add webpack 1 example #1452

merged 3 commits into from
Mar 19, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Mar 13, 2017

Ref: #524

@levithomason
Copy link
Member

This is great!

@codecov-io
Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #1452 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
+ Coverage   99.74%   99.74%   +<.01%     
==========================================
  Files         141      141              
  Lines        2363     2364       +1     
==========================================
+ Hits         2357     2358       +1     
  Misses          6        6
Impacted Files Coverage Δ
src/elements/Input/Input.js 100% <0%> (ø)
src/modules/Search/Search.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d05722...d5d15bc. Read the comment docs.

@layershifter
Copy link
Member Author

layershifter commented Mar 14, 2017

@levithomason I need you review there, pay attention to the text added to docs. I want to add same for rollup and webpack 2 in next PRs.

@levithomason
Copy link
Member

I've started a review here, will need to come back later to finish and submit it.

@levithomason
Copy link
Member

I have some comments, but, I want to first get some more examples merged before cleaning up too much.

@levithomason levithomason merged commit 630d8e0 into master Mar 19, 2017
@levithomason levithomason deleted the docs/bundlers branch March 19, 2017 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants