feat(Table) add missing Table alignment props #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1411 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 140 140
Lines 2347 2347
=======================================
Hits 2341 2341
Misses 6 6
Continue to review full report at Codecov.
|
levithomason
approved these changes
Mar 2, 2017
Add `textAlign` and 'verticalAlign' props to the Table component. ref: Semantic-Org#1389
Add tests for 'textAlign' and 'verticalAlign' props ref: Semantic-Org#1389
Document that the `textAlign` and `verticalAlign` props can be applied to the Table component. ref: Semantic-Org#1389
levithomason
force-pushed
the
table-alignment
branch
from
35f7b15
to
9329374
Compare
|
Superb thanks! We just refactored the typings so I rebased this branch and moved the Will merge on pass. |
|
😊 |
layershifter
reviewed
Mar 2, 2017
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Mar 8, 2017
* feat(Table): add missing Table alignment props Add `textAlign` and 'verticalAlign' props to the Table component. ref: Semantic-Org#1389 * test(Table): add tests for Table alignment props Add tests for 'textAlign' and 'verticalAlign' props ref: Semantic-Org#1389 * docs(Table): document Table text alignment props Document that the `textAlign` and `verticalAlign` props can be applied to the Table component. ref: Semantic-Org#1389 * Fix linting errors (missing trailing commas) * Update Table.d.ts
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Mar 8, 2017
* feat(Table): add missing Table alignment props Add `textAlign` and 'verticalAlign' props to the Table component. ref: Semantic-Org#1389 * test(Table): add tests for Table alignment props Add tests for 'textAlign' and 'verticalAlign' props ref: Semantic-Org#1389 * docs(Table): document Table text alignment props Document that the `textAlign` and `verticalAlign` props can be applied to the Table component. ref: Semantic-Org#1389 * Fix linting errors (missing trailing commas) * Update Table.d.ts
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
textAlignandverticalAlignprops to the Table component.Fixes #1389