fix(typings): Change some props of Search to optional #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenvg
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1407 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 140 140
Lines 2347 2347
=======================================
Hits 2341 2341
Misses 6 6Continue to review full report at Codecov.
|
|
Thanks, however, we just merged a major refactor to the typings structure. The files are now 1:1 with the JS filenames. Would you mind updating this PR to modify |
|
Not a problem, I'll update it tonight. |
koenvg
force-pushed
the
fix/searchTypings
branch
from
9fccbe0
to
6401d06
Compare
koenvg
force-pushed
the
fix/searchTypings
branch
from
6401d06
to
0db8c24
Compare
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Mar 8, 2017
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Mar 8, 2017
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the props of Search were wrongly labelled as mandatory.