fix(Dropdown|Select|Form): fixes in typings #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Feb 28, 2017
| @@ -8,7 +8,6 @@ import { | |||
| } from '../../modules/Dropdown'; | |||
|
|
|||
| export interface SelectProps extends DropdownProps { | |||
| selection: true; | |||
There was a problem hiding this comment.
true is not valid type, so it's cruft.
layershifter
commented
Feb 28, 2017
| @@ -46,10 +46,6 @@ interface FormProps { | |||
| widths?: 'equal'; | |||
| } | |||
|
|
|||
| interface FormOnSubmitData extends FormProps { | |||
layershifter
commented
Feb 28, 2017
| @@ -106,71 +106,71 @@ export interface DropdownProps { | |||
| * @param {SyntheticEvent} event - React's original SyntheticEvent. | |||
| * @param {object} data - All props. | |||
| */ | |||
| onBlur: (event: React.KeyboardEvent<HTMLElement>, data: DropdownProps) => void; | |||
| onBlur?: (event: React.KeyboardEvent<HTMLElement>, data: DropdownProps) => void; | |||
Codecov Report
@@ Coverage Diff @@
## master #1401 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 140 140
Lines 2347 2347
=======================================
Hits 2341 2341
Misses 6 6Continue to review full report at Codecov.
|
|
Whoops, I missed that one on review as well. Thanks for the update. |
|
Released in |
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Mar 8, 2017
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1400.