fix(Icon): Icon component PropType update to FontAwesome 4.7.0

[kamdz]

fixes #1371

I took names and aliases from changelog on here http://fontawesome.io/whats-new/

[levithomason]

SUI doesn't use font-awesome css classes directly, they are aliased to more "semantic" names. Example:

FA

SUI

See the line comment at the top of the SUI icons arrays which indicates where the names should be retrieved from in SUI core, namely, icon.css:

See https://github.com/Semantic-Org/Semantic-UI/blob/master/dist/components/icon.css#L486

Sidenote, looks like this file was updated 23hrs ago :) Thanks for the quick response to the change!

[levithomason]

This actually now has me wondering if/how we can achieve this programmatically. Perhaps that is for another PR, but it would be handy to auto parse this data from the installed semantic-ui-css package.

[kamdz]

Ok, I will change it. For now, manually...

[codecov-io]

Codecov Report

Merging #1372 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1372   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         140      140           
  Lines        2345     2345           
=======================================
  Hits         2339     2339           
  Misses          6        6

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76dfe9b...c4ae8e5. Read the comment docs.

[kamdz]

class names are now 1:1 to this from SUI-css

[levithomason]

Just one lint issue to fix

/home/ubuntu/Semantic-UI-React/src/lib/SUI.js
  59:1  error  Line 59 exceeds the maximum line length of 120  max-len

[levithomason]

Also could you please put fixes #1371 in the PR description in order to auto close the issue on merge? Thanks!

https://github.com/blog/1506-closing-issues-via-pull-requests

[layershifter]

Also, please update Icon typings file.

[kamdz]

@levithomason Done
@layershifter But why and how? Now it is:

/** Name of the icon. */
  name?: string;

and for me it's enough. If we change it to SUI.ICONS_AND_ALIASES then users can't set their own custom names for Icon component

[layershifter]

@kamdz Nevermind, I forgot that we don't have icons list in typings.

[levithomason]

/home/ubuntu/Semantic-UI-React/src/lib/SUI.js
  59:106  error  Trailing spaces not allowed  no-trailing-spaces

[kamdz]

done

[levithomason]

Thanks much!

[levithomason]

Released in [email protected].