Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(Popup): rename positioning to position #1342

Merged
merged 1 commit into from
Feb 21, 2017
Merged

breaking(Popup): rename positioning to position #1342

merged 1 commit into from
Feb 21, 2017

Conversation

kamdz
Copy link
Contributor

@kamdz kamdz commented Feb 17, 2017

as requested in #1259

(new pr)

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@36c5762). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1342   +/-   ##
=========================================
  Coverage          ?   99.74%           
=========================================
  Files             ?      140           
  Lines             ?     2394           
  Branches          ?        0           
=========================================
  Hits              ?     2388           
  Misses            ?        6           
  Partials          ?        0
Impacted Files Coverage Δ
src/modules/Popup/Popup.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c5762...b86bdb6. Read the comment docs.

@levithomason
Copy link
Member

Awesome, thank you very much!

@levithomason levithomason merged commit 7dd8173 into Semantic-Org:master Feb 21, 2017
@levithomason
Copy link
Member

Released in [email protected].

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants